Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused variables and imports #14

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Removing unused variables and imports #14

merged 1 commit into from
Aug 8, 2016

Conversation

tomasbjerre
Copy link
Contributor

No description provided.

@cdancy
Copy link
Owner

cdancy commented Aug 8, 2016

@tomasbjerre just getting back to review these changes now. We've had an ant-to-gradle followed by svn-to-git migration these past few weeks here and its been a little busy working on the automation for it all: my apologies. Thanks for breaking this out into a separate PR.

@cdancy cdancy merged commit 9ca8aa1 into cdancy:master Aug 8, 2016
@tomasbjerre
Copy link
Contributor Author

Sounds fun :)

I actually ended up not using this lib. Its really nice but I got problems
because of all the dependencies it adds to the classpath. It gave me
problems when using it in a Jenkins plugin.

Den 8 aug. 2016 16:51 skrev "Christopher Dancy" notifications@github.com:

@tomasbjerre https://github.com/tomasbjerre just getting back to review
these changes now. We've had an ant-to-gradle followed by svn-to-git
migration these past few weeks here and its been a little busy working on
the automation for it all: my apologies. Thanks for breaking this out into
a separate PR.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAa1E3rVfUhQyqHSfBwPaXqt0jv2sgDjks5qd0JngaJpZM4JYgWv
.

@cdancy
Copy link
Owner

cdancy commented Aug 8, 2016

@tomasbjerre really? What were the issues if you still have them? I do publish fat jar which should get around any dependency type of issues that may arise.

@cdancy
Copy link
Owner

cdancy commented Aug 8, 2016

@tomasbjerre also: if you're not going to continue on with the work I'm going to fork your branch and clean things up anyway. Now that we are live with gradle and git those backlog items I had, which you started coding for, are now needed by myself ;)

@cdancy cdancy added this to the v0.0.5 milestone Aug 8, 2016
@cdancy cdancy self-assigned this Aug 8, 2016
@tomasbjerre
Copy link
Contributor Author

Problem was with _guice-assistedinject_ I think Jenkins is using 4 och JClouds is using 3. I just tried it with the SNAPSHOT-version I build locally.

Ok, hope you find something you can use in my fork =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants